Added support of kerning to Text #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrew, Thank you for your work! I'll review it and merge in the beginning of the next week. |
|
What do think about make kerning property an optional property? |
|
I was thinking about this, however logically no kerning equals to kerning = 0, so I think zero value is fine. |
|
With and without 0 the kerning has different behaviour (look at link that I've added to my PR). |
|
Hi Andrew, I agree, no matter how it works, logically zero kerning means no kerning and we don't need to fix API to match current implementation. So your workaround is fine. I'm going to merge your patch now. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of kerning to Text.
Faced with a strange problem with kerning and phrase "Hello, world", but in other cases kerning has correct behaviour. I think, it is a bug of NSAttributedString.